Alexandre Emsenhuber [Wed, 20 Aug 2008 21:27:12 +0000 (21:27 +0000)]
Tweak for r29770 (yes, some months after it):
If the wiki is read only mode, don't show a "database locked" error if previewing or showing diff, but rather the "normal" action with a warning that the database is currently locked. If the user is trying to save the page, he'll see the preview page instead. Currently, if you are saving or previewing a page while the database is locked, you'll see the "database locked" error with the current text (or no text at all if the page doesn't exist), not your text, this might be confusing.
Also added the reason of the lock to the readonlywarning message.
Bryan Tong Minh [Wed, 20 Aug 2008 19:56:18 +0000 (19:56 +0000)]
Provide some info on which case value was not handled in ApiLogin
Aaron Schulz [Wed, 20 Aug 2008 19:26:43 +0000 (19:26 +0000)]
use quickUserCan()
Rotem Liss [Wed, 20 Aug 2008 19:23:04 +0000 (19:23 +0000)]
Localization update.
Guy Van den Broeck [Wed, 20 Aug 2008 19:19:36 +0000 (19:19 +0000)]
Escape characters that were unescaped by the parser
Siebrand Mazeland [Wed, 20 Aug 2008 19:16:12 +0000 (19:16 +0000)]
Fixes for r39727
Aaron Schulz [Wed, 20 Aug 2008 19:13:13 +0000 (19:13 +0000)]
function is not static
Guy Van den Broeck [Wed, 20 Aug 2008 19:09:27 +0000 (19:09 +0000)]
'Visual Comparison' added to messages
Guy Van den Broeck [Wed, 20 Aug 2008 18:45:43 +0000 (18:45 +0000)]
added diff headers for HTML diff
Brion Vibber [Wed, 20 Aug 2008 18:25:45 +0000 (18:25 +0000)]
fix for html diff on page with images -- ImageNode $attributes member was incorrectly declared as private
Rotem Liss [Wed, 20 Aug 2008 18:12:16 +0000 (18:12 +0000)]
Localization update.
Brion Vibber [Wed, 20 Aug 2008 18:11:59 +0000 (18:11 +0000)]
* $wgAjaxSearch has been removed; use $wgEnableMWSuggest instead.
I never liked the take-over-the-screen UI of the old ajax search; the new suggestion search does the same thing in a more natural, integrated way.
Greg Sabino Mullane [Wed, 20 Aug 2008 17:51:08 +0000 (17:51 +0000)]
Update to match postgres/tables.sql
Aaron Schulz [Wed, 20 Aug 2008 17:50:13 +0000 (17:50 +0000)]
redo allpages again less obtrusively
Rotem Liss [Wed, 20 Aug 2008 16:25:15 +0000 (16:25 +0000)]
Localization update for he.
Brion Vibber [Wed, 20 Aug 2008 16:13:49 +0000 (16:13 +0000)]
Revert r39416, 39421, 39427, 39489, 39515, 39516 "Rewrite allpages to use a "tree" of index range subpages (similar to the starting page) rather than one increasingly large range list (bug 13902)"
Breaks several aspects of paging behavior:
* Subpage parameter seems to have incorrectly changed from starting point to prefix
* We've lost forward and backward paging links
Andrew Garrett [Wed, 20 Aug 2008 14:12:52 +0000 (14:12 +0000)]
*ahem* self-revert. Something weird happened with getAll()
Andrew Garrett [Wed, 20 Aug 2008 14:08:50 +0000 (14:08 +0000)]
Use a nice fancy deep-merge function for merging arrays in SiteConfiguration (newly written), and move the merging of config options and globals deeper into get(), so we don't need to duplicate the same functionality in the entry points.
Shinjiman [Wed, 20 Aug 2008 13:45:43 +0000 (13:45 +0000)]
Localisation updates Cantonese, Chinese and Old/Late Time Chinese
Andrew Garrett [Wed, 20 Aug 2008 12:56:59 +0000 (12:56 +0000)]
Add "+setting" type code (adding to the existing global) into getAll, since that is what we use on Wikimedia
Andrew Garrett [Wed, 20 Aug 2008 12:30:31 +0000 (12:30 +0000)]
PHP Sucks. Having a value of 0 was making $value appear as false, so you couldn't set a value when adding an option. Fixed this up with a strict check.
Aaron Schulz [Wed, 20 Aug 2008 09:43:46 +0000 (09:43 +0000)]
Load messages in a less shitty and more consistent manner for extensions. Previously relied on logName() being called. Failed miserably for extracts.
Aaron Schulz [Wed, 20 Aug 2008 08:40:37 +0000 (08:40 +0000)]
* Profile a tad more
* Code style tweak
Aaron Schulz [Wed, 20 Aug 2008 08:24:10 +0000 (08:24 +0000)]
minor refactoring
Brion Vibber [Wed, 20 Aug 2008 02:22:50 +0000 (02:22 +0000)]
Disable the time limit during full-history export
Brion Vibber [Wed, 20 Aug 2008 01:40:35 +0000 (01:40 +0000)]
Part two of allowing Special:Export to work on very long page histories...
Part 1 was disabling the output buffers, allowing us to stream output continuously.
Part 2, here, is to use an unbuffered query to load the page/revision data, as we do for the command-line scripts. (This is done in what Tim assures me is a portable, database-neutral way, unlike all the maint scripts which still use old hacks.) This lets us actually stream the *input* -- otherwise streaming the output is darn useless!
Part 3 will be fixing up things like the max execution time. :)
Aaron Schulz [Wed, 20 Aug 2008 01:03:01 +0000 (01:03 +0000)]
Remark static functions for performance. Same 15 test failures as before this change.
Brion Vibber [Tue, 19 Aug 2008 23:27:33 +0000 (23:27 +0000)]
* (bug 15230) Revert r38207 arbitrary removal of capitalization from individual group member name while similar usages such as the plural group name remain capitalized.
Brion Vibber [Tue, 19 Aug 2008 21:24:47 +0000 (21:24 +0000)]
Add another parser test for whitespace before the number-px, just for good measure. That one was in use on pages on frwiki
Brion Vibber [Tue, 19 Aug 2008 21:10:56 +0000 (21:10 +0000)]
2 new PASSING test(s) :)
* Width-sized image (using px, no following whitespace) [Has never failed]
* Width-sized image (using px, with following whitespace - test regression from r39467) [Has never failed]
Brion Vibber [Tue, 19 Aug 2008 20:59:18 +0000 (20:59 +0000)]
Revert Parser.php to r39295 good state.
Whitespace handling for image width magic words failed, possibly other problems.
NEEDS PARSER TESTS
Brion Vibber [Tue, 19 Aug 2008 20:32:30 +0000 (20:32 +0000)]
* $wgSpamRegex now matches the edit summary and page move descriptions in
addition to body text.
Could use some cleanup to the error display on page moves; it recycles the general edit notice for spam hits currently, which is pretty big on English Wikipedia, and doesn't say what match you hit.
Alexandre Emsenhuber [Tue, 19 Aug 2008 19:27:13 +0000 (19:27 +0000)]
Fix variable name, per report of Smaug on IRC
Brion Vibber [Tue, 19 Aug 2008 19:11:27 +0000 (19:11 +0000)]
Revert r39625 "Run autocreated accounts through AbortNewAccount hooks"
This seems to be mixing UI and backend code.
Further I'm unsure we want to treat authplugin autocreations as "new accounts" for this purpose; since they *have* been previously created and perhaps approved, just blindly running it through the same abort hook again will be a huge pain in the butt, for instance for those who had to go through admin approval due to a machine-detected name spoof conflict or an IP blocking issue. If an abort is appropriate, it should probably be a distinct hook so it can be treated differently.
Chad Horohoe [Tue, 19 Aug 2008 19:10:07 +0000 (19:10 +0000)]
Move the call to view() for Action::purge() up from doPurge() to purge(). Kinda like last time, only less broken. Calling Article::doPurge() now lets the backend do a purge without output (and doesn't turn Article::purge() into a UI and backend entry, which is good)
Brion Vibber [Tue, 19 Aug 2008 19:05:23 +0000 (19:05 +0000)]
Revert r39623 "Use array_merge_recursive instead of array_merge for merging settings."
I do not think array_merge_recursive does what you think it does. It looks like it would spectacularly corrupt things.
Brion Vibber [Tue, 19 Aug 2008 18:58:50 +0000 (18:58 +0000)]
Reverting r39619 "(bug 13689) Page output can be suppressed on Article::purge() by passing bool false to it. Default (ie: nearly 100+% of the time) is true."
Article::purge() is a UI action entry point, not a backend method. Backend-only parameters aren't appropriate here; instead a method suitable for backend usage should be created (and/or in an ideal world, we should finish splitting Article backend stuff from UI frontend as separate classes)
Brion Vibber [Tue, 19 Aug 2008 18:45:32 +0000 (18:45 +0000)]
Revert r39608 "More descriptive sanitized paths for file repo errors"
This doesn't look like it'll work -- it appears to be using string interpolations in single-quoted strings?
Can you test some error conditions w/ this and show some before and after examples?
Brion Vibber [Tue, 19 Aug 2008 17:40:00 +0000 (17:40 +0000)]
Revert r39582 "(bug 12518) Interwiki userrights now reflects remote groups, not local groups."
This won't actually work -- it checks the InitialiseSettings.php conf array for $wgGroupPermissions, but we don't set $wgGroupPermissions individually for every wiki. We use a system of several override variables which get applied in CommonSettings.php onto the default template.
Brion Vibber [Tue, 19 Aug 2008 17:24:23 +0000 (17:24 +0000)]
Revert r39546 "(bug 14187) In Special:Userlogin the buttons "Log in" and "E-mail new password" now have classes "mw-loginbutton" and "mw-mailmypasswordbutton"."
There's no need to add classes when they already have IDs...
Bryan Tong Minh [Tue, 19 Aug 2008 15:08:14 +0000 (15:08 +0000)]
Fix up my name.
Roan Kattouw [Tue, 19 Aug 2008 15:05:29 +0000 (15:05 +0000)]
API:
* BREAKING CHANGE: list={backlinks,embeddedin,imageusage} now return an array with keys 0, 1, 2, ... (list) rather than an array with pageIDs as keys (hash table/associative array) for consistency with other list= modules.
* Attempting to fix an error about "Invalid title ``''" (i.e. empty string as title) I encountered at Wikipedia.
Alexandre Emsenhuber [Tue, 19 Aug 2008 13:59:05 +0000 (13:59 +0000)]
Added some missing developers to CREDITS
Rotem Liss [Tue, 19 Aug 2008 08:13:18 +0000 (08:13 +0000)]
Localization update for he.
Daniel Friesen [Tue, 19 Aug 2008 04:44:34 +0000 (04:44 +0000)]
Committing todays work on LinkHooks and the link rewrite:
* Cleanup and remove cruft
* Get hooks working
* Get Categories working (whitespace trimming not done)
Chad Horohoe [Tue, 19 Aug 2008 03:48:26 +0000 (03:48 +0000)]
Tweak comment: fixed it but didn't remove the fixme.
Purodha B Blissenbach [Tue, 19 Aug 2008 02:24:46 +0000 (02:24 +0000)]
fix Bug 15240 Special:Search uses wrong data in PLURAL
with MediaWiki:Showingresultstotal, introducing $4 = count of results on
this page.
Shinjiman [Tue, 19 Aug 2008 02:13:31 +0000 (02:13 +0000)]
Update the Chinese conversion tables
Shinjiman [Tue, 19 Aug 2008 02:08:12 +0000 (02:08 +0000)]
Localisation updates Cantonese, Chinese and Old/Late Time Chinese
Fran Rogers [Tue, 19 Aug 2008 02:00:43 +0000 (02:00 +0000)]
Run autocreated accounts through AbortNewAccount hooks
Daniel Friesen [Tue, 19 Aug 2008 01:19:19 +0000 (01:19 +0000)]
Revert 39613; Please don't mark that function static. It is not called statically, and is not meant to be. That is meant as a test to see if there are any markers inside of part of the string being worked on.
Ideally in the future markers will have unique identifier so that using multiple link marker replacers don't clash with each other.
Andrew Garrett [Tue, 19 Aug 2008 01:11:02 +0000 (01:11 +0000)]
Use array_merge_recursive instead of array_merge for merging settings.
Brion Vibber [Tue, 19 Aug 2008 00:15:05 +0000 (00:15 +0000)]
Revert r39503, 39507 "(bug 14468) Lines in classic RecentChanges and Watchlist now have classes "odd" and "even" to make colouring using css possible."
These alternating background colors are imho not very attractive, and make the display busy and confusing, rather than easier to read.
Siebrand Mazeland [Mon, 18 Aug 2008 22:34:28 +0000 (22:34 +0000)]
Localisation updates for core messages from Betawiki (2008-08-19 00:18 CEST)
Chad Horohoe [Mon, 18 Aug 2008 22:21:13 +0000 (22:21 +0000)]
(bug 13689) Page output can be suppressed on Article::purge() by passing bool false to it. Default (ie: nearly 100+% of the time) is true.
Aaron Schulz [Mon, 18 Aug 2008 21:03:59 +0000 (21:03 +0000)]
Use !== here
Aaron Schulz [Mon, 18 Aug 2008 20:52:24 +0000 (20:52 +0000)]
Use more simple strict comparisons
Roan Kattouw [Mon, 18 Aug 2008 20:48:45 +0000 (20:48 +0000)]
(bug 15228) Throw a warning instead of an error when revids= and redirects are combined. Also fixed a bug that caused warnings thrown in ApiPageSet.php to appear in an <ApiPageSet> tag rather than <query>
Aaron Schulz [Mon, 18 Aug 2008 20:38:34 +0000 (20:38 +0000)]
mark static
Aaron Schulz [Mon, 18 Aug 2008 20:27:35 +0000 (20:27 +0000)]
mark static functions
Chad Horohoe [Mon, 18 Aug 2008 20:27:05 +0000 (20:27 +0000)]
Remove last of $wgEnablePersistentCookies. Use > 0 checks on $wgCookieExpiration instead. Also typo in my docs.
Fran Rogers [Mon, 18 Aug 2008 20:06:16 +0000 (20:06 +0000)]
More descriptive sanitized paths for file repo errors
Chad Horohoe [Mon, 18 Aug 2008 19:57:01 +0000 (19:57 +0000)]
Remove boneheaded config var $wgEnablePersistentCookies. Setting the default expiration to 0 now makes the cookies session-only (seeing as it was largely ignored)
Alexandre Emsenhuber [Mon, 18 Aug 2008 19:48:28 +0000 (19:48 +0000)]
* Missing svn:eol-style property on Parser_LinkHooks.php
* Fixed syntax error CoreLinkFunctions.php
Alexandre Emsenhuber [Mon, 18 Aug 2008 19:37:44 +0000 (19:37 +0000)]
*stab* forgot to commit that file
Alexandre Emsenhuber [Mon, 18 Aug 2008 19:21:55 +0000 (19:21 +0000)]
Tweaks for Credits and Metadata:
* Put all functions into classed so that they can be autoloaded
* Marked all private methods as protected
* Article::getContributors() now returns UserArrayFromResult object
Aryeh Gregor [Mon, 18 Aug 2008 18:15:47 +0000 (18:15 +0000)]
Re-committing 37663 for the new release, per old Wikitech-l discussion.
* (bug 13815) In the comment for page moves, use the colon-separator message instead of a hardcoded colon.
* So that this works properly, don't escape HTML entities in edit summaries. I don't see any good reason for them to be escaped there. Of course, this may result in old edit summaries displaying slightly differently if for some reason they included an entity, but in that case there's at least a 50% chance that they intended it to not be escaped in the first place.
Fran Rogers [Mon, 18 Aug 2008 18:11:43 +0000 (18:11 +0000)]
Restore r39518 with fix. No need to be snarky :/
Rotem Liss [Mon, 18 Aug 2008 18:03:49 +0000 (18:03 +0000)]
Testing commit access, per report. Minor whitespace change.
Aaron Schulz [Mon, 18 Aug 2008 17:38:11 +0000 (17:38 +0000)]
Revert r39518. Fucks up type selector. Does anybody test this stuff?
Rotem Liss [Mon, 18 Aug 2008 17:22:12 +0000 (17:22 +0000)]
Fix regression from r39373: * marks were changed to *? , which broke the colon in comments because the regexp did not recognize the post text. Reverting to the original regexp. Tested on some comments (as well as on Wikipedia:Translation/*/Lang/de mentioned in the previous commit), but if it breaks anything, please revert and fix in another way.
Siebrand Mazeland [Mon, 18 Aug 2008 16:21:06 +0000 (16:21 +0000)]
(bug 13856) Make Greek omicron available in math notation. Patch by Colin Hall
Chad Horohoe [Mon, 18 Aug 2008 15:36:53 +0000 (15:36 +0000)]
No-ops for getSearchEngine().
Rotem Liss [Mon, 18 Aug 2008 15:23:45 +0000 (15:23 +0000)]
Localization update for he.
Chad Horohoe [Mon, 18 Aug 2008 15:22:00 +0000 (15:22 +0000)]
Remove DB logic from SearchEngine. New method in Database and associated subclasses called getSearchEngine() does this now.
Guy Van den Broeck [Mon, 18 Aug 2008 14:55:36 +0000 (14:55 +0000)]
Using referenses inside of foreach loops.
Rotem Liss [Mon, 18 Aug 2008 14:51:10 +0000 (14:51 +0000)]
Avoid notices: Before checking if retval is an array, check if it is defined.
Daniel Friesen [Mon, 18 Aug 2008 14:44:51 +0000 (14:44 +0000)]
Committing today's work the LinkHooks' new parser.
Don't expect this to work completely yet, there is likely going to be a lot of refactoring before a final version is complete.
Alexandre Emsenhuber [Mon, 18 Aug 2008 14:19:12 +0000 (14:19 +0000)]
Use colon-separator message after summary, summary-preview, subject and subject-preview instead of hardcoding a ":" after it
Roan Kattouw [Mon, 18 Aug 2008 13:48:44 +0000 (13:48 +0000)]
Cleaned up HTMLDiff implementation for readability:
* Coding style consistency and indentation
* Removed unneccesary require_once(), the AutoLoader will load the right file automatically
* sizeof -> count, TRUE -> true, FALSE -> false, NULL -> null
* Use Xml:: functions
* Rename TagNode::splitUntill() to splitUntil() and $hasNotDeletedDescendant to $hasNonDeletedDescendant
* Flip TagNode::$blocks, TagToStringFactory::$containerTags and TagToStringFactory::$styleTags
* Merging if's in Node::getParentTree()
* Use a smart foreach() loop rather than two while()s and an if() in TagNode::splitUntil()
* Put all of TextNodeDiffer's members on top rather than scattering them between functions
* Use PHP's double-quoted string coolness rather than sprintf() or concatenation
* Use a smart foreach loop rather than array_keys() and a for() in TagToString::addAttributes()
TODO:
* Use interface messages rather than TagToString::$bundle so they can be translated
* Use constants for magic numbers like 1.35, 1000 and 2000 in calls to WikiDiff3::__construct()
Siebrand Mazeland [Mon, 18 Aug 2008 13:26:46 +0000 (13:26 +0000)]
Fix for r39314 (adding the new toggles to $mToggles in User.php)
Andrew Garrett [Mon, 18 Aug 2008 12:50:30 +0000 (12:50 +0000)]
Allow use of +setting to add to that setting as it is (for arrays), rather than to replace it. Together with the previous commit to this file, we don't need to use groupOverrides/groupOverrides2 anymore
Andrew Garrett [Mon, 18 Aug 2008 12:41:57 +0000 (12:41 +0000)]
(bug 12518) Interwiki userrights now reflects remote groups, not local groups.
Andrew Garrett [Mon, 18 Aug 2008 09:26:48 +0000 (09:26 +0000)]
Allowed array-merging for site config. You can now set a setting for '+whatever', and it's the same as setting it for 'whatever', merged with the contents of the next level up. Should mean we're able to deprecate the ugly groupOverrides/groupOverrides2 syntax in InitialiseSettings.php.
Aaron Schulz [Mon, 18 Aug 2008 07:59:37 +0000 (07:59 +0000)]
add profile calls
Aaron Schulz [Mon, 18 Aug 2008 06:50:12 +0000 (06:50 +0000)]
Add optional $db param
Aaron Schulz [Mon, 18 Aug 2008 05:58:54 +0000 (05:58 +0000)]
fix broken profiling
Aaron Schulz [Mon, 18 Aug 2008 05:50:03 +0000 (05:50 +0000)]
profile out
Daniel Friesen [Mon, 18 Aug 2008 03:56:38 +0000 (03:56 +0000)]
Create a placeholder for the LinkHook experimentation.
This will allow us to develop a new method of parsing links (non-hacky), without breaking current syntax, and also allow us to make sure new methods don't break syntax.
Currently this class merely inherits from the Parser class. Constants and static functions are coppied so that use of self:: won't break when we modify things.
Aaron Schulz [Mon, 18 Aug 2008 03:30:36 +0000 (03:30 +0000)]
be more specific in error
Aaron Schulz [Mon, 18 Aug 2008 02:36:34 +0000 (02:36 +0000)]
disable compression
Guy Van den Broeck [Mon, 18 Aug 2008 00:16:32 +0000 (00:16 +0000)]
Performance improvements to diff algorithms
Aaron Schulz [Sun, 17 Aug 2008 21:58:17 +0000 (21:58 +0000)]
flag as protected
Chad Horohoe [Sun, 17 Aug 2008 21:29:05 +0000 (21:29 +0000)]
New RELEASE-NOTES belong at the bottom :)
Daniel Kinzler [Sun, 17 Aug 2008 21:08:58 +0000 (21:08 +0000)]
add new option $wgRestrictDisplayTitle
Siebrand Mazeland [Sun, 17 Aug 2008 19:25:19 +0000 (19:25 +0000)]
(bug 14187) In Special:Userlogin the buttons "Log in" and "E-mail new password" now have classes "mw-loginbutton" and "mw-mailmypasswordbutton".
Chad Horohoe [Sun, 17 Aug 2008 15:55:48 +0000 (15:55 +0000)]
Use wfMsgExt() with parsemag instead of wfMsg().
Chad Horohoe [Sun, 17 Aug 2008 15:45:08 +0000 (15:45 +0000)]
{{PLURAL}}-ize 'siteusers'
Siebrand Mazeland [Sun, 17 Aug 2008 11:06:04 +0000 (11:06 +0000)]
Tweak 'categoriespagetext' further.
Siebrand Mazeland [Sun, 17 Aug 2008 10:00:06 +0000 (10:00 +0000)]
Localisation updates for core messages from Betawiki (2008-08-17 11:50 CEST)